<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/103530/">http://git.reviewboard.kde.org/r/103530/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Samikshan and sorry for late review.
I really like this options page, but I've got a few ideas that you might want to use. Here they are:
1) Should checkboxes be tristate? I don't see much use for this here.
2) The entire form looks good, but I'd decrease spacing between "Enable/Disable Supernova alerts" checkbox and "Update..." button. I'd do the same with spacing between this button and magnitude limits.
3) "Enable/Disable Supernova alerts" - shouldn't it be named "Enable Supernova alerts"? After all it's the checkbox that represents this "Enable/Disable" part ;-)
4) It would be nice to have consistent capitalization of "Supernovae" in all labels of this form.
As you can see, these are all cosmetic changes. I haven't noticed other problems :-)
</pre>
<br />
<p>- Rafal</p>
<br />
<p>On December 25th, 2011, 11:34 a.m., Samikshan Bairagya wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KStars, Rafal Kulaga and Akarsh Simha.</div>
<div>By Samikshan Bairagya.</div>
<p style="color: grey;"><i>Updated Dec. 25, 2011, 11:34 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Worked on the problems of my earlier review request and fixed them. There's no icon for Supernova now. Users can choose to either have or not have supernovae on their skymap. Notifications for new supernovae is not yet implemented.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kstars/kstarsactions.cpp <span style="color: grey">(15d2552)</span></li>
<li>kstars/kstarsdcop.cpp <span style="color: grey">(c045e47)</span></li>
<li>kstars/options/opssupernovae.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/options/opssupernovae.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/options/opssupernovae.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>kstars/CMakeLists.txt <span style="color: grey">(6f7ed20)</span></li>
<li>kstars/kstars.h <span style="color: grey">(aa76633)</span></li>
<li>kstars/kstars.kcfg <span style="color: grey">(986f322)</span></li>
<li>kstars/skycomponents/supernovaecomponent.h <span style="color: grey">(ab824c6)</span></li>
<li>kstars/skycomponents/supernovaecomponent.cpp <span style="color: grey">(5c3c8bb)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/103530/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Screenshots </h1>
<div>
<a href="http://git.reviewboard.kde.org/r/103530/s/381/"><img src="http://git.reviewboard.kde.org/media/uploaded/images/2011/12/25/SupernovaDialog_1_400x100.png" style="border: 1px black solid;" alt="Dialog window for Supernova" /></a>
</div>
</td>
</tr>
</table>
</div>
</body>
</html>