[Kstars-devel] Review Request: Fix bug that causes KStars to crash (segmentation fault) in Options window, before TLEs update.

[Rafal Kulaga]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102332/#review5726
-----------------------------------------------------------

Ship it!


Nice job Łukasz! I would also advise you to change these three lines that Aleksey mentioned. When it's done, push this commit to the master branch by issuing 'git push origin master'.

- Rafal


On Aug. 15, 2011, 6:27 p.m., Łukasz Jaśkiewicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102332/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2011, 6:27 p.m.)
> 
> 
> Review request for KStars, Victor Carbune, Rafal Kulaga, and Akarsh Simha.
> 
> 
> Summary
> -------
> 
> Patch that fixes KStars crashing when Options window was closed, before TLEs are update. Crash was in OpsSatellites::slotItemChanged(), because before TLEs are updated, parent of item which was accessed was 0x0. This patch also fixes view's header (it was '1' because model was cleared after header was set) and makes items read-only.
> 
> 
> Diffs
> -----
> 
>   kstars/options/opssatellites.cpp 7d4fc88 
> 
> Diff: http://git.reviewboard.kde.org/r/102332/diff
> 
> 
> Testing
> -------
> 
> Tested, fixes the problem.
> 
> 
> Thanks,
> 
> Łukasz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20110815/3e95b822/attachment.html>