[Kstars-devel] Review Request: Fix bug that causes KStars to crash (segmentation fault) in Options window, before TLEs update.

[Aleksey Khudyakov]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/102332/#review5723
-----------------------------------------------------------

Ship it!


I believe you refer to bug 279028[1] so please add line "CCBUG: 279028" (without quotes). I'll close bug in the meantime

Fix looks fine. I have only stylistic advice. IMHO one liner on 97 would be more readable than three lines.

> m_Model->setHorizontalHeaderLabels( QStringList( i18n( "Satellite name" ) ) );


[1] https://bugs.kde.org/show_bug.cgi?id=279028

- Aleksey


On Aug. 15, 2011, 6:27 p.m., Łukasz Jaśkiewicz wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/102332/
> -----------------------------------------------------------
> 
> (Updated Aug. 15, 2011, 6:27 p.m.)
> 
> 
> Review request for KStars, Victor Carbune, Rafal Kulaga, and Akarsh Simha.
> 
> 
> Summary
> -------
> 
> Patch that fixes KStars crashing when Options window was closed, before TLEs are update. Crash was in OpsSatellites::slotItemChanged(), because before TLEs are updated, parent of item which was accessed was 0x0. This patch also fixes view's header (it was '1' because model was cleared after header was set) and makes items read-only.
> 
> 
> Diffs
> -----
> 
>   kstars/options/opssatellites.cpp 7d4fc88 
> 
> Diff: http://git.reviewboard.kde.org/r/102332/diff
> 
> 
> Testing
> -------
> 
> Tested, fixes the problem.
> 
> 
> Thanks,
> 
> Łukasz
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kstars-devel/attachments/20110815/3b4c68d7/attachment.html>