[Kstars-devel] branches/kstars/carbonix/kstars

[Alexey Khudyakov]

On Sun, 30 May 2010 18:04:57 +0200 (CEST)
Victor Carbune <victor.carbune at gmail.com> wrote:

> SVN commit 1132408 by vcarbune:
> 
> Migrated the information regarding Deep Sky Objects from the text files
> (ngcic.dat, image_url.dat, info_url.dat) to the database.
> 
> Directly added the generated database in the data directory (kstars.db) The
> database can also be generated using the KStarsDB class (example in
> DeepSkyComponent::loadData()) The files image_url_full.dat and
> info_url_full.dat are the original files, used to create the database
> 
> Review request. Benchmarks show that improvements still need to be done
> (working on them).  The ASCII File was loaded in about 1 sec, while the db is
> being loaded in 2 sec (timer, in the code) The loading speed will actually be
> important on bigger datasets (not just ngcic.dat) The file has 1MB, while the
> db has 2MB.
> 

Wouldn't it be better to keep text files and generate database using some script
maybe during build. This gives more control on database structure and knowledge
about conversion won't became lost (It happens)

Also file `kstars.db' is missing. Did you forget to include it?

-- 
Alexey Khudyakov <alexey.skladnoy at gmail.com>