[Kstars-devel] KDE/kdeedu/kstars/kstars

Alexey Khudyakov alexey.skladnoy at gmail.com
Fri Feb 12 21:33:55 CET 2010


SVN commit 1089286 by khudyakov:

Change signatures of member functions of SkyPoint
namely: ra,ra0,dec,dec0,az,alt

Now they return const reference to dms instead of pointer. Main
reason bhid this change is to use plain dumb assignment for angles
For example following code snippets could be found in KStars sources

> a1.setH( p->ra().Hours() );

Actually it is plain assignment but in obscure form and rather ineffective.
It include two multiplications. Following code is equivalent:

> a1 = p->ra();

Much easier to understand.

Change is very extensive but fairly trivial. At the very least code
does compile and seems to work.

CCMAIL: kstars-devel at kde.org

 M  +4 -4      comast/execute.cpp  
 M  +2 -2      comast/log.cpp  
 M  +20 -20    dialogs/detaildialog.cpp  
 M  +27 -27    indi/indistd.cpp  
 M  +3 -3      ksalmanac.cpp  
 M  +1 -1      kspopupmenu.cpp  
 M  +2 -2      kstars.cpp  
 M  +11 -11    kstarsactions.cpp  
 M  +2 -2      kstarsdata.cpp  
 M  +4 -4      kstarsdcop.cpp  
 M  +1 -1      kstarsinit.cpp  
 M  +3 -3      skycomponents/constellationboundarylines.cpp  
 M  +2 -2      skycomponents/ecliptic.cpp  
 M  +14 -14    skycomponents/horizoncomponent.cpp  
 M  +3 -3      skycomponents/satellitecomponent.cpp  
 M  +1 -1      skycomponents/skymapcomposite.cpp  
 M  +28 -28    skycomponents/skymesh.cpp  
 M  +82 -79    skymap.cpp  
 M  +1 -1      skymap.h  
 M  +8 -8      skymapdraw.cpp  
 M  +37 -37    skymapevents.cpp  
 M  +2 -2      skyobjects/deepskyobject.cpp  
 M  +2 -2      skyobjects/jupitermoons.cpp  
 M  +2 -2      skyobjects/ksplanet.cpp  
 M  +14 -14    skyobjects/ksplanetbase.cpp  
 M  +2 -2      skyobjects/kssun.cpp  
 M  +5 -5      skyobjects/skyline.cpp  
 M  +13 -16    skyobjects/skyobject.cpp  
 M  +26 -26    skyobjects/skypoint.cpp  
 M  +14 -28    skyobjects/skypoint.h  
 M  +15 -15    skyobjects/starobject.cpp  
 M  +5 -5      tools/altvstime.cpp  
 M  +8 -8      tools/flagmanager.cpp  
 M  +2 -2      tools/modcalcaltaz.cpp  
 M  +3 -3      tools/modcalcapcoord.cpp  
 M  +1 -1      tools/modcalceclipticcoords.cpp  
 M  +1 -1      tools/modcalcgalcoord.cpp  
 M  +10 -10    tools/modcalcplanets.cpp  
 M  +4 -4      tools/modcalcplanets.h  
 M  +5 -5      tools/modcalcvizequinox.cpp  
 M  +2 -2      tools/modcalcvlsr.cpp  
 M  +32 -32    tools/observinglist.cpp  
 M  +3 -3      tools/obslistwizard.cpp  
 M  +5 -5      tools/wutdialog.cpp  
 M  +4 -4      widgets/infoboxwidget.cpp  


http://websvn.kde.org/?view=rev&revision=1089286


More information about the Kstars-devel mailing list