[Kstars-devel] Refined patch for wishlist 178232: List all objects within a rectangle

Abhijit Apte abhijit.apte at gmail.com
Mon Feb 1 19:45:34 CET 2010


Hi Alexey/Akarsh,

On Mon, Feb 1, 2010 at 2:21 PM, Abhijit Apte <abhijit.apte at gmail.com> wrote:

> I've implemented a draft of the implementation of combining the list
> functionality along-side the detail dialog. So in essence, we'll have only
> one dialog which will operate in two modes -- Detailed and Summary.
> 1) When a popup menu is invoked on a sky object and "Details..." option is
> selected from the popup menu, the detail dialog will open in "Detailed" mode
> by default. User has the option to switch to the "Summary" view also.
> 2) When a right-click drag selection happens, the objects from the
> rectangle are shown in the detail dialog. This time, the detail dialog will
> open in "Summary" mode.
>

Here's the patch, I managed to fix most of the bugs I noticed while testing.
Right now, I've not modified DetailDialog (dialogs/detaildialog.cpp and
dialogs/detaildialog.h) and instead merged (copied) all of its code into
dialogs/objectlist.cpp and dialogs/objectlist.h
Pl. review and apply the patch and suggest me if you've any comments.

Still to do:
1) Move all the modified code of dialogs/objectlist.* back to
dialogs/detaildialog.* and remove dialogs/objectlist.* files
2) Update the CMakeLists.txt to reflect the changes of step 1.

Rgds
-Abhi
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.kde.org/pipermail/kstars-devel/attachments/20100202/a97ba0ec/attachment-0001.htm 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: patch1feb.diff
Type: text/x-patch
Size: 71021 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kstars-devel/attachments/20100202/a97ba0ec/attachment-0001.diff 


More information about the Kstars-devel mailing list