[Kstars-devel] signal for DateBox in planetviewer (Solar System Viewer) broken

Lukas Middendorf lukas.middendorf at freenet.de
Thu Nov 19 20:17:48 CET 2009


Hi,

I found that in planetviewer.cpp a wrong signal has been used and therefore no 
changes to the DateBox were ever applied to the simulation.

I also found that the parameter of PlanetViewer::slotChangeDate() was unused 
and seemed senseless.

The first of the attached patches just fixes the signal, the second one also 
removes the unused parameter. Just choose one.

Is there any good reason why the name in the code differs from the name in the 
program itself? There are some other dialogs that are hard to find in code 
because they have two different names.

Regards,
Lukas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: planetviewer_1.diff
Type: text/x-patch
Size: 839 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kstars-devel/attachments/20091119/a33e61c2/attachment.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: planetviewer_2.diff
Type: text/x-patch
Size: 1461 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kstars-devel/attachments/20091119/a33e61c2/attachment-0001.diff 


More information about the Kstars-devel mailing list