[Kstars-devel] atempted fix for bug 210886

Lukas Middendorf lukas.middendorf at freenet.de
Fri Nov 6 16:16:03 CET 2009


Am Friday 06 November 2009 schrieb Khudyakov Alexey:
> Only could you use
> 
> > if( condition )
> >     someAction();
> 
> instead of
> 
> > if( condition ) someAction()
> 
> It's easier to read code this way

I tried to resemble the code for wut in the same file, but I have changed that 
now


> Patch for detail dialog will leak memory. DetailDialog isn't going to be
> deleted. It could be adressed with setAttribute(Qt::WA_DeleteOnClose)

I guessed that this might be happening.

> and QPointer usage is superficial. Raw pointer will do just fine.

Sure.

I have two new patches.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 210886_1.diff
Type: text/x-patch
Size: 1514 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kstars-devel/attachments/20091106/ba90da95/attachment.diff 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 210886_2.diff
Type: text/x-patch
Size: 664 bytes
Desc: not available
Url : http://mail.kde.org/pipermail/kstars-devel/attachments/20091106/ba90da95/attachment-0001.diff 


More information about the Kstars-devel mailing list