[Kstars-devel] Astrocalc refactoring

Khudyakov Alexey alexey.skladnoy at gmail.com
Tue May 19 09:59:53 CEST 2009


> > 04-astrocalc_dispatch_map_refactor.patch
> >
> > gen{Time,Coord,Solar}Text functions are removed.
> >
> > All dispatching in slotItemSelection is done via maps instead of long
> > ladder of `ifs'. Item name appears in source code only once.
>
> Can you confirm that this does not modify any i18n() strings? It looks
> like it doesn't, but just want to be sure.
>
Yes. I extracted strings from file. They did not changed only duplicates are 
removed and big ones are moved around. 

> > 05-astrocalc_clean_refactor.patch
> >
> > Unneeded data fields are removed.
>
> I'll commit the last two sometime soon. The last one failed to merge,
> so I need some time to commit it. In the meantime, if someone wants to
> commit these two patches, they could go ahead!
>
patch 05-* applies cleanly for me but it depends on changes made by 04-*






More information about the Kstars-devel mailing list