[Kstars-devel] Astrocalc refactoring

Akarsh Simha akarshsimha at gmail.com
Tue May 19 06:49:43 CEST 2009


Hi Alexey

Thanks for the patches. I'm sorry I commited them in so late.

I've commited the first three patches.

> 04-astrocalc_dispatch_map_refactor.patch
> 
> gen{Time,Coord,Solar}Text functions are removed. 
> 
> All dispatching in slotItemSelection is done via maps instead of long ladder 
> of `ifs'. Item name appears in source code only once.  

Can you confirm that this does not modify any i18n() strings? It looks
like it doesn't, but just want to be sure.

> 05-astrocalc_clean_refactor.patch
> 
> Unneeded data fields are removed. 

I'll commit the last two sometime soon. The last one failed to merge,
so I need some time to commit it. In the meantime, if someone wants to
commit these two patches, they could go ahead!

Thanks once again.

Regards
Akarsh


More information about the Kstars-devel mailing list