[Kstars-devel] KDE/kdeedu/kstars/kstars/skyobjects

[Akarsh Simha]

On Wed, Jun 03, 2009 at 02:12:01PM +0000, Alexey Khudyakov wrote:
> SVN commit 977139 by khudyakov:
> 
> In this changeset clone function is implemented. It allows safe
> copying of objects. E.g. KSPlanet stored as SkyObject* pointer
> would be copied as KSPlanet and not sliced. 
> 
> For all subclasses of SkyObject but DeepSkyObject copy
> constructors are removed. In most cases they are pretty useless
> and could be replaced with default implementations. 
> 
> * Changes in copy constructors
>  - Trail in TrailObject wasn't copied. Now it's copied
>  - const annotation added in DeepSkyObject copy constructor
> 
> * Overloaded assignment operator in EclipticPosition
>   (skyobjects/ksplanetbase.h) removed. Default
>   implementation would be just fine too.
> 
> Please note, despite the fact that a lot of files are changed
> only conjustion tool is affected by this change. Objects of
> SkyObject class family are not copied much.

No regressions for sure?

Particularly "dangerous" areas are Conjunctions, Planets section of
AstroCalculator and the Deep Star Component, as far as I can remember.

We're about to tag KDE 4.3 Beta tomorrow, so I'd appreciate if someone
could test out for problems.

Regards
Akarsh