[Kstars-devel] Reorganisation of the sources layout
James Bowlin
bowlin at mindspring.com
Mon Feb 23 08:07:23 CET 2009
On Sun February 22 2009, Médéric Boquien wrote:
> i propose to reorganise then as follows:
> * optional compoments (indi, cfitsio, xplanet) are entirely
> self-contained in their own directory
> * the icons move to icons/
> * the options move to options/
> * all other dialogs move to dialogs/
> * the base classes for sky bodies (ksplanet.* for instance) move to
> skybodies
> * the related objects (starobject.* for instance) move to skyobjects
> * skycomponents is renamed as skymapcomponents
I like this idea!
Here is a suggestion: the classes in your skybodies/ directory are
descendants of SkyObject so I think they would go better in the
skyobjects/ directory because they are all SkyObjects, although
they might go into a subdirectory under skyobjects/. I think
the directory structure should follow the class structure where
this is possible. Also, some of the classes that you have in the
skyobjects/ directory are not SkyObject descendants which could
be confusing.
Likewise, most of the files in skycomponents/ are subclasses of
SkyComponent so the current directory name makes sense to me.
I think we might run into a consistency problem when some subdirectories
follow the class structure and others follow the functionality. I'd be
willing to live with this inconsistency if we add a README file that
explains the directory layout. Perfect is the enemy of good.
> Of course i volunteer to move the files once we agree.
Moving the files is the easy part. Changing the #include's will be
more work, I suspect.
Also, Akarsh might be using this time to make substantial modifications
so we would want to coordinate the commits for the minimum disturbance
of ongoing work.
--
Peace, James
More information about the Kstars-devel
mailing list