[Kstars-devel] Simplification KStarsData init.

[Khudyakov Alexey]

В сообщении от Воскресенье 16 августа 2009 00:56:25 автор Médéric Boquien 
написал:
> > No, it's only second. First place rightfully belongs to saturnmoons.
> > That's the real mess. (-:
>
> I am not sure what you are refering to here exactly.
skyobjects/saturnmoons.{h,cpp} 
It's code that induce horror (-:


> > I've simplified initialization code a little. However because everything
> > is very convoluted and depends on each other I had to refactor SkyMap a
> > lot. Patchset is big ~20 patches. They affect KStars and SkyMap classes.
> > So if you have work that could be damaged by carpet patch-bombing tell me
> > I'll wait with commit.
>
> Nothing here.
>
I'll commit rest tomorrow if no one complain. 


> I think it is the right moment to do that, we are still early in the cycle
> to be able to catch most problems (if any).
>
> > P.S. I found that there are a lot of unused code in KStars. Do anyone
> > knows methods to find unused functions automatically. It would make
> > refactoring easier.
>
> That would be useful too. Kstars went from KDE 2 to KDE 3 to KDE 4, it is
> not surprising that there are some leftovers here and there. I have no idea
> how to find unused methods though.
>
I use grep. It works but it's tiresome and it's easy to miss something.