[Kstars-devel] Conjunctions tool backends, a few bugfixes

[Jason Harris]

Hi Akarsh,

Some comments on KSConjunct:

It seems to me that the only function that will need to be called from  
outside the class is findClosestApproach().  If that's correct, then  
the other functions should be made private.

Also, since nothing is instantiated when creating a KSConjunct object,  
we don't really need to have one.  In other words, I suggest making  
findClosestApproach() a static function, so that it can be called  
externally without having to instantiate a KSConjunct object.  It's  
also good form to make the constructor private if all public functions  
are static, so that it isn't possible to create a KSConjunct object.   
Have a look at ksutils.[h|cpp] for an example of a class like this.

Finally, a feature request: it might be nice to eventually allow for  
conjunctions between planetary bodies and any SkyObject.  For example,  
the Moon sometimes passes in front of bright stars.

Other than those comments, it's looking good.  Thanks again for  
contributing!

regards,
Jason


On Apr 17, 2008, at 12:56 AM, Akarsh Simha wrote:

> Hello
>
> I fixed the bug in the conjunctions tool backend and it now works
> beautifully. I tested it only against two planets (Mars vs Jupiter),
> and it gave out correct results. But I suppose it should work equally
> well for other planets as well.
>
> I would request someone to design an interface for this, as I
> mentioned in a previous email.
>
> Also attached is a small patch with a few documentation bugfixes, and
> a fix to Bug #147917 in the code, which requires re-generation of the
> template file for complete fixing.
>
> The bugfix to cities.dat has to do with renaming of Indian
> cities, that happened quite a few years back, with cities officially
> adopting regional names.
>
> ksconjunct.h and ksconjunct.cpp need to be put into the
> /kstars/kstars/tools directory.
>
> Regards
> Akarsh.
> <patch_20080417.tar.gz>_______________________________________________
> Kstars-devel mailing list
> Kstars-devel at kde.org
> https://mail.kde.org/mailman/listinfo/kstars-devel