[Kstars-devel] removing KStars::privatedata class

[Heiko Evermann]

Hi Jason,
> I'd like to remove the KStars::privatedata class (declared at the end of
> kstars.h).  It just contains pointers for the KStars, KStarsData, and
> KStarsSplash objects, as well as the buildGUI() function.  I don't really
> see the purpose of this class; the KStarsData and KStarsSplash objects and
> the buildGUI() function can just as well be members of KStars instead.
The idea is that the main class does not change whenever the internal data 
structure changes. Otherwise adding an internal member forces a recompile of 
the whole application. 
>
> I guess this class was created to conform to the "d-pointer" style of KDE
> coding.  However, since we are not a library, we don't really need to
> maintain BC.
It is good programming style all around the C++-world. 
>
> If there are no arguments for keeping privatedata, I'll remove it as part
> of my current effort to simplify the startup proceudres.
As a private-data-class only keeps member variables and as it is created  
during the creation of the its object and deleted during the corresponding 
destructor, removing this will probably not simplyfy anything.

Kind regards,

Heiko