[Kst] 2 small issues

[Nicolas Brisset]

Hi Barth,

I have seen and tested your 2 commits for my 2 issues: they work fine, thanks a lot!

Regarding your comments wrt updates of the vector list, you're right with the vectorselector: the user won't notice so your solution is perfectly OK.
For the flat list with all vectors visible (until you have too many...) it is more of an issue. My idea was not to update whenever a vector is added to the store, which happens behind the scenes and does not interest the user, but rather to trigger it when one or more vectors have been created from the datawizard or the create menu. 
Now, thinking a bit more about it I realize that filters and plugins also create vectors, so it's not just those 2 actions. 
Ideally, we would need to find the place to update the views at the end of any user-triggered action. 
I more or less thought it was the purpose of MainWindow::updateViewItems, but I may have been wrong. I don't understand all the subtleties of the update system...

Not a high-priority, but maybe worth thinking about it.

Nicolas

----- Mail original -----
> De: "Barth Netterfield" <barth.netterfield at utoronto.ca>
> À: kst at kde.org
> Envoyé: Vendredi 25 Octobre 2013 02:24:36
> Objet: Re: [Kst] 2 small issues
> 
> The problem with doing it every time a vector is added to the store
> (my original idea) is that you end up with some n^2 badness when you
> add n vectors. (say from the data wizard).
> 
> The problem with doing it whenever the object gains focus is that it
> doesn't change until it gains focus, which, while not harmful from a
> work-flow perspective, looks kind of unprofessional. This isn't an
> issue for the vector selector combos because the items are added to
> the bottom of the list, which isn't visible unless it is selected.
> 
> Let's go with my current solution for now, and we can revisit it if
> it is too annoying.
>