[Kst] [Bug 234396] The ASCII datasource config widget no longer honors "Apply these settings as default"

Nicolas Brisset nicolas.brisset at eurocopter.com
Thu Apr 22 08:15:02 CEST 2010


Nicolas Brisset <nicolas.brisset at eurocopter.com> changed:

           What    |Removed                     |Added
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED

--- Comment #1 from Nicolas Brisset <nicolas brisset eurocopter com>  2010-04-22 08:15:00 ---
SVN commit 1117430 by brisset:

When reading a file with the ASCII datasource, always load ASCII defaults
before attempting to load file-specific settings (asciisourceconfig.cpp).
Also avoid overriding those defaults with hard-coded values when no key exists
for the given file (namedparameter.h). That issue is actually more a problem
that the test in asciisourceconfig.cpp / AsciiSourceConfig::readGroup is not
specific enough: fileName.isEmpty() triggers too easily => if the file has no
settings stored, we still try to read its settings and since we find nothing we
revert to hard-coded default values. With this patch, the constructor sets
hard-coded defaults, then we override them with the ASCII source's general
defaults, then with file-specific values, but only if there are some in
QSettings. If you think this patch is wrong, we have to find a way to test for
the existence of settings for the given file instead of just testing whether
the filename is empty.

BUG: 234396

 M  +2 -3      asciisourceconfig.cpp  
 M  +1 -3      namedparameter.h  

WebSVN link: http://websvn.kde.org/?view=rev&revision=1117430

Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

More information about the Kst mailing list