[Kst] Release Plan...

[Eli Fidler]

The patches were reviewed, but not committed since 1.4.0 wasn't packaged yet. 
I didn't CC the list before, so here are the comments I sent:

144048 (commit 653135): looks ok
144050 (commit 653138): looks clearly ok
144099 (commit 653140): Adam has a good point that the variables shouldn't be 
declared at the start of the function. I think functionality is ok
144108 (commit 653245): George previously reviewed this. I agree it's fine. 
Doesn't cause any regressions for me.
144372 (commit 657638): Looks fine, although perhaps the changed() signal 
should not be emitted if you press up on the first item or down on the last 
item? Maybe the buttons shouldn't even be enabled?
144644: not sure which bug this actually is... 144644 is a digikam bug

Eli

On May 1, 2007 15:41:24 Andrew Walker wrote:
> I think the plan was that Eli would have reviewed the patches a week ago.
> I agree that Friday is now tight. However, if the plan is to change, Barth
> should be in the loop.
>
> -----Original Message-----
> From: George Staikos [mailto:staikos at kde.org]
> Sent: May 1, 2007 12:37 PM
> To: kst at kde.org
> Subject: Re: [Kst] Release Plan...
>
>
>
> We need far more testing and these patches need to be reviewed
> carefully first.  Basically if we're putting in this many more
> patches I need to start over with my testing.  Friday is tight then.
>
> On 1-May-07, at 3:27 PM, Andrew Walker wrote:
> > I think the point here was that the listed changes would be part of
> > 1.4.0.
> > Eli was asked to confirm these fixes and check them into 1.4.0,
> > which would
> > then be packaged with those changes. If you want to change this
> > plan I think
> > Barth should give his agreement first.
> >
> > Andrew
> >
> > -----Original Message-----
> > From: George Staikos [mailto:staikos at kde.org]
> > Sent: May 1, 2007 10:49 AM
> > To: kst at kde.org
> > Subject: Re: [Kst] Release Plan...
> >
> > On 27-Apr-07, at 8:00 PM, Barth Netterfield wrote:
> >> The releases have been delayed - 1.4.0 has been delayed to the time
> >> we had
> >> planned 1.4.1: it will be packaged Friday, May 4.
> >>
> >> The bug fixes which had been planned for 1.4.1, and which have
> >> already been
> >> applied to 1.5 should be reviewed, and applied to 1.4.0.  These are
> >>
> >> [Bug 144108] Superscript cannot be used to start a label
> >> [Bug 144099] New: Kst freezes when plotting data
> >> [Bug 144050] New: Up/Down arrows in Plot Content skip too many
> >> [Bug 144048] New: Legends ignore font colour
> >> [Bug 144372] apply enabled.
> >> [Bug 144644] Scalars starting with a '.'
> >>
> >> Eli: can you review and commit these - hopefully by the end of
> >> Monday - to
> >> give the week for testing these changes?
> >>
> >> George, can you package up again on Friday?
> >
> >    Yes but I am still building packages out of trunk so please do not
> > modify it yet.
>
> --
> George Staikos
> KDE Developer				http://www.kde.org/
> Staikos Computing Services Inc.		http://www.staikos.net/
>
>
>
> _______________________________________________
> Kst mailing list
> Kst at kde.org
> https://mail.kde.org/mailman/listinfo/kst
>
>
>
> _______________________________________________
> Kst mailing list
> Kst at kde.org
> https://mail.kde.org/mailman/listinfo/kst