[Kst] [Bug 111239] Ability to easily setup supressed axis plots

[George Staikos]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=111239         




------- Additional Comments From staikos kde org  2006-06-21 21:23 -------
Quoting Andrew Walker <arwalker sumusltd com>:

> 1) I don't see that any decision has been reached. If the proposed plan is 

to
> move everything to a manager class then I think a seperate bug report should
> be entered as it will impact much more than just this code.


   It's not a bug or a user-facing feature, but you can file one if you want.

> 2) I'm interested in all the entries


  The patch is blocked until this is cleared up, and this is not clear.  
Either the code is iterating and doing expensive dynamic casts before popping 
up a menu (which causes significant lag), or there is code missing in the 
patch.

> 4) widget()->paint(QRegion()) calls
>    KstWidget::paintEvent(...) calls
>    KstTopLevelView::paint(KstPainter::P_PAINT);
> (with nothing else going on in any of those functions)
> where presently we're simply calling
>    KstTopLevelView::paint(KstPainter::P_PAINT);
> 
> At present all the places that a paint is triggered from KstTopLevelView
> calls the paint directly.


   Correct.  And the proper way to do it is to paint the widget.  Eventually 
all calls to paint the widget will be propagated up further into the app too.

> If this should change for all cases then I think a
> separate bug report is needed.


  It is something that will change eventually, but not now.  It's not worth 
introducing new bugs by changing something that works.  I don't want to 
propagate incorrect code either, so it has to use the new paint rules.  This 
change in painting procedure was implemented and announced many months ago and 
needs to be followed.