[Kst] [Bug 111239] Ability to easily setup supressed axis plots
netterfield at physics.utoronto.ca
Wed Jun 21 17:54:32 CEST 2006
On one hand we could argue that it is like a special case of cleanup layout,
and should go in the same place as the cleanup layout code. On the other
hand, we could argue that because it is 2dplot specific, it should exist
In any case, it is very localized, whereever it goes, and can easily be moved.
Would it be acceptable for items 2-4 to be fixed, and to then have it
commited so we can start to test the behavior of the feature, and then move
it to where it belongs once you decide (which would hopefully be soon)?
location has been decided.
This will be a very nice feature for many-paneled real time plots (which
pretty much always use the same X range.)
On Tuesday 20 June 2006 20:23, George Staikos wrote:
> ------- Additional Comments From staikos kde org 2006-06-21 05:23 -------
> I have a lot of comments about this patch. To start:
> 1) I don't like the fact that this is in ksttoplevelview. I'm not entirely
> sure where it should go yet. If we are going to have plot management code
> at a global level, maybe it should be implemented in a manager class.
> 2) Don't iterate and kst_cast<> the whole selection list when all you care
> about is two entries; kst_cast is expensive.
> 3) Creating a sub list already exists in the form of a template function
> kstObjectSubList<>. That should be used instead of home-grown sub-list
> extraction. I know it does unnecessary locking, but it allows us to change
> this code in all locations in one shot when needed - and it was needed many
> times in the past.
> 4) No object is ever supposed to paint() directly anymore. This is a
> serious policy violation. The paint should be done on the view widget
> itself. _______________________________________________
> Kst mailing list
> Kst at kde.org
More information about the Kst