[Kst] [Bug 111239] Ability to easily setup supressed axis plots
staikos at kde.org
Wed Jun 21 05:23:32 CEST 2006
------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
------- Additional Comments From staikos kde org 2006-06-21 05:23 -------
I have a lot of comments about this patch. To start:
1) I don't like the fact that this is in ksttoplevelview. I'm not entirely
sure where it should go yet. If we are going to have plot management code at
a global level, maybe it should be implemented in a manager class.
2) Don't iterate and kst_cast<> the whole selection list when all you care
about is two entries; kst_cast is expensive.
3) Creating a sub list already exists in the form of a template function
kstObjectSubList<>. That should be used instead of home-grown sub-list
extraction. I know it does unnecessary locking, but it allows us to change
this code in all locations in one shot when needed - and it was needed many
times in the past.
4) No object is ever supposed to paint() directly anymore. This is a serious
policy violation. The paint should be done on the view widget itself.
More information about the Kst