[Kst] extragear/graphics/kst/src/libkstapp
Barth Netterfield
netterfield at astro.utoronto.ca
Fri Jun 2 14:56:35 CEST 2006
AFAIR, for a while, we misused "padding" (instead of margin). Padding is
currently undefined/buggy for legends. If you ever have padding set to
anything other than 0, (say through scripts) you will get a borked legend.
We need to maintain compatibility with .kst files saved from official release,
and we would also like to maintain compatibility with any DR we released.
So we can:
-in the legend object set padding to zero until someone makes padding do
something non-broken (put in a FIXME but not a bug - but I can see this
biting us someday... if ever do fix padding for legends)
-recognize file version and fix on read (don't think this is possible)
-fix padding on legends now so it does something non-broken when it is
non-zero (probably the best thing to do)
-???? (something else)
But I really don't think that users should have to be fixing our mistakes.
cbn
On Friday 02 June 2006 05:26, George Staikos wrote:
> On Thursday 01 June 2006 14:08, Andrew Walker wrote:
> > There is no way for the user to now set the padding. The user has control
> > only over the _legendMargin. This was probably different in the past and
> > whoever made the change did not consider the repercussions.
>
> There is via KstScript. The user can change both. This is specifically
> why hacking around functionality and design is wrong. Now matter which way
> it is done, something is "broken". I would rather we know that old Kst
> files are broken in this respect and tell users to fix it by typing in a
> bit of script or recreating their legends, than have some hacky code in
> there that breaks things down the road (or is removed and brings us right
> back to where we started).
More information about the Kst
mailing list