[Kst] kdeextragear-2/kst/kst

[Andrew Walker]

I would agree its useful to leave in comments that indicate the reason
a change was made, when the change is potentially unclear or obscure.

Its considerably less useful to simply leave commented code. A few days 
later it is unclear why it was commented out; whether it is old code waiting 
to be deleted, new code waiting to be activated, etc.

On Tuesday 14 December 2004 11:03, you wrote:
> On Tuesday 14 December 2004 13:50, Andrew Walker wrote:
> > CVS commit by arwalker:
> >
> > Use more meaningful variable names.
> > Indent correctly.
> > Remove obsolete check.
> > -                        //if (lastPlottedX != d2i(X2) || index >=
> > MAX_NUM_POLYLINES-2) { if (index >= MAX_NUM_POLYLINES-2) {
>
>   Sometimes it's useful to leave these in, or at least a comment in English
> about why it was removed.  For instance, in the change Barth did in
> KstViewWidget, instead of removing the code, he left a comment with reasons
> why it was removed and left the code in.  Although I changed it again
> within a few hours, it was very useful to have that there.  It could have
> easily been re-added without understanding the implications resulting in
> its removal.