[Kst] kdeextragear-2/kst/kst

George Staikos staikos at kde.org
Tue Dec 14 20:03:41 CET 2004


On Tuesday 14 December 2004 13:50, Andrew Walker wrote:
> CVS commit by arwalker:
>
> Use more meaningful variable names.
> Indent correctly.
> Remove obsolete check.
> -                        //if (lastPlottedX != d2i(X2) || index >=
> MAX_NUM_POLYLINES-2) { if (index >= MAX_NUM_POLYLINES-2) {

  Sometimes it's useful to leave these in, or at least a comment in English 
about why it was removed.  For instance, in the change Barth did in 
KstViewWidget, instead of removing the code, he left a comment with reasons 
why it was removed and left the code in.  Although I changed it again within 
a few hours, it was very useful to have that there.  It could have easily 
been re-added without understanding the implications resulting in its 
removal.

-- 
George Staikos
KDE Developer				http://www.kde.org/
Staikos Computing Services Inc.		http://www.staikos.net/



More information about the Kst mailing list