[Ksecretservice-devel] libs

[Alin Marin Elena]

Hi Valentin,

on the daemon lib... you are right... initially I thought they should
be shared...  and that is why I added it. Then I left them static to
ask you first.

on the inclusion into kde... that is a great news. I do not know how
about the variable you indicated... but if it is provided by the kde4
macros is simple to replace the one that I created.


regards,
Alin



On 8 August 2011 17:51, Valentin Rusu <kde at rusu.info> wrote:
> On 08/08/2011 04:51 PM, Alin Marin Elena wrote:
>> Hi Valentin,
>>
>> I have attached a proper patch now...
> Thanks for the patch.
> As I see from it, you add version information to the daemon's static
> libraries. But these libraries are only intended for internal
> modularization, as the daemon is composed of two layers. As such, these
> libraries do not need version information.
> Other than that, KSecretsService will go inside kdelibs and
> kde-workspace, so I prefer adding KDE's GENERIC_LIB_VERSION in the
> dynamic libraries.
> I also added a version.h file, that will install in the includes
> directory and that's also used by the daemon for it's version
> information. Remember that theses two pieces, client and daemon,
> versions should always match.
>> in the daemon folder you have some kde4_add_library with static attribute is
>> that ok?
> Yes - see above.
>> regards,
>> Alin
> Cheers,
> Valentin
>
>