[KPhotoAlbum] mapview-patch

Johannes Zarl-Zierl johannes at zarl-zierl.at
Fri Jan 1 23:12:28 GMT 2021

Hi Reimar,

Am Donnerstag, 31. Dezember 2020, 15:43:16 CET schrieb Reimar Imhof:
> thanks, your change is ok.

Thanks for the feedback.

> A little question: You added a
> 	event->ignore();
> Should that also be added 3 lines above after the
> 	if (event->button() != Qt::LeftButton)
> before the return-statement (of course, adding {...})?

I assumed that the ignore() call was omitted for a reason. Turns out it seems 
ok without it. Both with or without it doesn't make much difference in this 
case, but I'll fix it to be consistent with best practices...


More information about the Kphotoalbum mailing list