[KPhotoAlbum] Load-performance branch
Angel Lopez
anglopm at gmail.com
Sun Jun 3 08:53:29 BST 2018
Dear Robert,
I'm trying to compile your Load-performance brach, but I'm getting compiler
errors:
First, I got a :
/home/angel/src/kphotoalbum-Load-performance/MainWindow/Window.cpp:1761:6:
error: no declaration matches ‘void
MainWindow::Window::slotOptimizeThumbnails()’
void MainWindow::Window::slotOptimizeThumbnails()
^~~~~~~~~~
/home/angel/src/kphotoalbum-Load-performance/MainWindow/Window.cpp:1761:6:
nota: no functions named ‘void MainWindow::Window::slotOptimizeThumbnails()’
I fixed that including a declaration in MainWindow.h
Now I got these errors:
In file included from /usr/include/qt/QtCore/qnamespace.h:43,
from /usr/include/qt/QtCore/qobjectdefs.h:48,
from /usr/include/qt/QtCore/qobject.h:46,
from /usr/include/qt/QtCore/QObject:1,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:
In member function 'void RemoteControl::RemoteConnection::dataReceived()':
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:108:52:
error: no matching function for call to 'asString(qint32&)'
<< ": Received " << qPrintable(id);
^~~~~~~~~~
In file included from /usr/include/qt/QtCore/qobject.h:47,
from /usr/include/qt/QtCore/QObject:1,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:
/usr/include/qt/QtCore/qstring.h:1862:23: note: candidate: 'const QString&
QtPrivate::asString(const QString&)' <near match>
inline const QString &asString(const QString &s) { return s; }
^~~~~~~~
/usr/include/qt/QtCore/qstring.h:1862:23: note: conversion of argument 1
would be ill-formed:
In file included from /usr/include/qt/QtCore/qnamespace.h:43,
from /usr/include/qt/QtCore/qobjectdefs.h:48,
from /usr/include/qt/QtCore/qobject.h:46,
from /usr/include/qt/QtCore/QObject:1,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:108:63:
error: invalid user-defined conversion from 'qint32' {aka 'int'} to 'const
QString&' [-fpermissive]
<< ": Received " << qPrintable(id);
^~
In file included from /usr/include/qt/QtCore/qobject.h:47,
from /usr/include/qt/QtCore/QObject:1,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:
/usr/include/qt/QtCore/qstring.h:829:5: note: candidate is:
'QString::QString(const char*)' <near match>
QString(const char *ch);
^~~~~~~
/usr/include/qt/QtCore/qstring.h:829:5: note: conversion of argument 1
would be ill-formed:
In file included from /usr/include/qt/QtCore/qnamespace.h:43,
from /usr/include/qt/QtCore/qobjectdefs.h:48,
from /usr/include/qt/QtCore/qobject.h:46,
from /usr/include/qt/QtCore/QObject:1,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:108:63:
error: invalid conversion from 'qint32' {aka 'int'} to 'const char*'
[-fpermissive]
<< ": Received " << qPrintable(id);
^~
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:108:52:
error: 'QString::QString(const char*)' is private within this context
<< ": Received " << qPrintable(id);
^~~~~~~~~~
In file included from /usr/include/qt/QtCore/qobject.h:47,
from /usr/include/qt/QtCore/QObject:1,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:
/usr/include/qt/QtCore/qstring.h:829:5: note: declared private here
QString(const char *ch);
^~~~~~~
In file included from /usr/include/qt/QtCore/qnamespace.h:43,
from /usr/include/qt/QtCore/qobjectdefs.h:48,
from /usr/include/qt/QtCore/qobject.h:46,
from /usr/include/qt/QtCore/QObject:1,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:108:63:
error: invalid conversion from 'qint32' {aka 'int'} to 'const char*'
[-fpermissive]
<< ": Received " << qPrintable(id);
^~
In file included from /usr/include/qt/QtCore/qobject.h:47,
from /usr/include/qt/QtCore/QObject:1,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:
/usr/include/qt/QtCore/qstring.h:829:25: note: initializing argument 1 of
'QString::QString(const char*)'
QString(const char *ch);
~~~~~~~~~~~~^~
/usr/include/qt/QtCore/qstring.h:1863:18: note: candidate: 'QString&&
QtPrivate::asString(QString&&)' <near match>
inline QString &&asString(QString &&s) { return std::move(s);
}
^~~~~~~~
/usr/include/qt/QtCore/qstring.h:1863:18: note: conversion of argument 1
would be ill-formed:
In file included from /usr/include/qt/QtCore/qnamespace.h:43,
from /usr/include/qt/QtCore/qobjectdefs.h:48,
from /usr/include/qt/QtCore/qobject.h:46,
from /usr/include/qt/QtCore/QObject:1,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:108:63:
error: invalid user-defined conversion from 'qint32' {aka 'int'} to
'QString&&' [-fpermissive]
<< ": Received " << qPrintable(id);
^~
In file included from /usr/include/qt/QtCore/qobject.h:47,
from /usr/include/qt/QtCore/QObject:1,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:
/usr/include/qt/QtCore/qstring.h:829:5: note: candidate is:
'QString::QString(const char*)' <near match>
QString(const char *ch);
^~~~~~~
/usr/include/qt/QtCore/qstring.h:829:5: note: conversion of argument 1
would be ill-formed:
In file included from /usr/include/qt/QtCore/qnamespace.h:43,
from /usr/include/qt/QtCore/qobjectdefs.h:48,
from /usr/include/qt/QtCore/qobject.h:46,
from /usr/include/qt/QtCore/QObject:1,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:108:63:
error: invalid conversion from 'qint32' {aka 'int'} to 'const char*'
[-fpermissive]
<< ": Received " << qPrintable(id);
^~
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:108:52:
error: 'QString::QString(const char*)' is private within this context
<< ": Received " << qPrintable(id);
^~~~~~~~~~
In file included from /usr/include/qt/QtCore/qobject.h:47,
from /usr/include/qt/QtCore/QObject:1,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:
/usr/include/qt/QtCore/qstring.h:829:5: note: declared private here
QString(const char *ch);
^~~~~~~
In file included from /usr/include/qt/QtCore/qnamespace.h:43,
from /usr/include/qt/QtCore/qobjectdefs.h:48,
from /usr/include/qt/QtCore/qobject.h:46,
from /usr/include/qt/QtCore/QObject:1,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:108:63:
error: invalid conversion from 'qint32' {aka 'int'} to 'const char*'
[-fpermissive]
<< ": Received " << qPrintable(id);
^~
In file included from /usr/include/qt/QtCore/qobject.h:47,
from /usr/include/qt/QtCore/QObject:1,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:
/usr/include/qt/QtCore/qstring.h:829:25: note: initializing argument 1 of
'QString::QString(const char*)'
QString(const char *ch);
~~~~~~~~~~~~^~
In file included from /usr/include/qt/QtCore/qnamespace.h:43,
from /usr/include/qt/QtCore/qobjectdefs.h:48,
from /usr/include/qt/QtCore/qobject.h:46,
from /usr/include/qt/QtCore/QObject:1,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,
from
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:
/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:108:52:
error: conversion to non-const reference type 'class QString&&' from rvalue
of type 'QString' [-fpermissive]
<< ": Received " << qPrintable(id);
^~~~~~~~~~
make[2]: *** [CMakeFiles/kphotoalbum.dir/build.make:3053:
CMakeFiles/kphotoalbum.dir/RemoteControl/RemoteConnection.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:69: CMakeFiles/kphotoalbum.dir/all]
Error 2
make: *** [Makefile:141: all] Error 2
Now, I have no idea about what to do. Could be related to Qt version?
I'm on Arch Linux and Qt-5.11
Regards, and thanks for your efforts to make kphotoalbum even better !!!
______________________________
----------- Angel ------------
2018-06-02 17:37 GMT+02:00 Robert Krawitz <rlk at alum.mit.edu>:
> BTW, has anyone else tested the load performance branch? This offers
> enough improvements when loading images (functional -- image stacking
> at load now fully works -- in addition to performance), and the
> possibility of fixing some threading issues, that I'd like to get it
> merged.
>
> --
> Robert Krawitz <rlk at alum.mit.edu>
>
> *** MIT Engineers A Proud Tradition http://mitathletics.com ***
> Member of the League for Programming Freedom -- http://ProgFree.org
> Project lead for Gutenprint -- http://gimp-print.sourceforge.net
>
> "Linux doesn't dictate how I work, I dictate how Linux works."
> --Eric Crampton
> _______________________________________________
> KPhotoAlbum mailing list
> KPhotoAlbum at mail.kdab.com
> https://mail.kdab.com/mailman/listinfo/kphotoalbum
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kphotoalbum/attachments/20180603/c452b5c5/attachment.htm>
More information about the Kphotoalbum
mailing list