<div dir="ltr"><div>Dear Robert,</div><div><br></div><div>I'm trying to compile your Load-performance brach, but I'm getting compiler errors:</div><div>First, I got a :</div><div><br></div><div>/home/angel/src/kphotoalbum-Load-performance/MainWindow/Window.cpp:1761:6: error: no declaration matches ‘void MainWindow::Window::slotOptimizeThumbnails()’<br> void MainWindow::Window::slotOptimizeThumbnails()<br> ^~~~~~~~~~<br>/home/angel/src/kphotoalbum-Load-performance/MainWindow/Window.cpp:1761:6: nota: no functions named ‘void MainWindow::Window::slotOptimizeThumbnails()’<br><br></div><div>I fixed that including a declaration in MainWindow.h</div><div><br></div><div>Now I got these errors:</div><div><br></div><div>In file included from /usr/include/qt/QtCore/qnamespace.h:43,<br> from /usr/include/qt/QtCore/qobjectdefs.h:48,<br> from /usr/include/qt/QtCore/qobject.h:46,<br> from /usr/include/qt/QtCore/QObject:1,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:<br>/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp: In member function 'void RemoteControl::RemoteConnection::dataReceived()':<br>/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:108:52: error: no matching function for call to 'asString(qint32&)'<br> << ": Received " << qPrintable(id);<br> ^~~~~~~~~~<br>In file included from /usr/include/qt/QtCore/qobject.h:47,<br> from /usr/include/qt/QtCore/QObject:1,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:<br>/usr/include/qt/QtCore/qstring.h:1862:23: note: candidate: 'const QString& QtPrivate::asString(const QString&)' <near match><br> inline const QString &asString(const QString &s) { return s; }<br> ^~~~~~~~<br>/usr/include/qt/QtCore/qstring.h:1862:23: note: conversion of argument 1 would be ill-formed:<br>In file included from /usr/include/qt/QtCore/qnamespace.h:43,<br> from /usr/include/qt/QtCore/qobjectdefs.h:48,<br> from /usr/include/qt/QtCore/qobject.h:46,<br> from /usr/include/qt/QtCore/QObject:1,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:<br>/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:108:63: error: invalid user-defined conversion from 'qint32' {aka 'int'} to 'const QString&' [-fpermissive]<br> << ": Received " << qPrintable(id);<br> ^~<br>In file included from /usr/include/qt/QtCore/qobject.h:47,<br> from /usr/include/qt/QtCore/QObject:1,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:<br>/usr/include/qt/QtCore/qstring.h:829:5: note: candidate is: 'QString::QString(const char*)' <near match><br> QString(const char *ch);<br> ^~~~~~~<br>/usr/include/qt/QtCore/qstring.h:829:5: note: conversion of argument 1 would be ill-formed:<br>In file included from /usr/include/qt/QtCore/qnamespace.h:43,<br> from /usr/include/qt/QtCore/qobjectdefs.h:48,<br> from /usr/include/qt/QtCore/qobject.h:46,<br> from /usr/include/qt/QtCore/QObject:1,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:<br>/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:108:63: error: invalid conversion from 'qint32' {aka 'int'} to 'const char*' [-fpermissive]<br> << ": Received " << qPrintable(id);<br> ^~<br>/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:108:52: error: 'QString::QString(const char*)' is private within this context<br> << ": Received " << qPrintable(id);<br> ^~~~~~~~~~<br>In file included from /usr/include/qt/QtCore/qobject.h:47,<br> from /usr/include/qt/QtCore/QObject:1,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:<br>/usr/include/qt/QtCore/qstring.h:829:5: note: declared private here<br> QString(const char *ch);<br> ^~~~~~~<br>In file included from /usr/include/qt/QtCore/qnamespace.h:43,<br> from /usr/include/qt/QtCore/qobjectdefs.h:48,<br> from /usr/include/qt/QtCore/qobject.h:46,<br> from /usr/include/qt/QtCore/QObject:1,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:<br>/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:108:63: error: invalid conversion from 'qint32' {aka 'int'} to 'const char*' [-fpermissive]<br> << ": Received " << qPrintable(id);<br> ^~<br>In file included from /usr/include/qt/QtCore/qobject.h:47,<br> from /usr/include/qt/QtCore/QObject:1,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:<br>/usr/include/qt/QtCore/qstring.h:829:25: note: initializing argument 1 of 'QString::QString(const char*)'<br> QString(const char *ch);<br> ~~~~~~~~~~~~^~<br>/usr/include/qt/QtCore/qstring.h:1863:18: note: candidate: 'QString&& QtPrivate::asString(QString&&)' <near match><br> inline QString &&asString(QString &&s) { return std::move(s); }<br> ^~~~~~~~<br>/usr/include/qt/QtCore/qstring.h:1863:18: note: conversion of argument 1 would be ill-formed:<br>In file included from /usr/include/qt/QtCore/qnamespace.h:43,<br> from /usr/include/qt/QtCore/qobjectdefs.h:48,<br> from /usr/include/qt/QtCore/qobject.h:46,<br> from /usr/include/qt/QtCore/QObject:1,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:<br>/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:108:63: error: invalid user-defined conversion from 'qint32' {aka 'int'} to 'QString&&' [-fpermissive]<br> << ": Received " << qPrintable(id);<br> ^~<br>In file included from /usr/include/qt/QtCore/qobject.h:47,<br> from /usr/include/qt/QtCore/QObject:1,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:<br>/usr/include/qt/QtCore/qstring.h:829:5: note: candidate is: 'QString::QString(const char*)' <near match><br> QString(const char *ch);<br> ^~~~~~~<br>/usr/include/qt/QtCore/qstring.h:829:5: note: conversion of argument 1 would be ill-formed:<br>In file included from /usr/include/qt/QtCore/qnamespace.h:43,<br> from /usr/include/qt/QtCore/qobjectdefs.h:48,<br> from /usr/include/qt/QtCore/qobject.h:46,<br> from /usr/include/qt/QtCore/QObject:1,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:<br>/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:108:63: error: invalid conversion from 'qint32' {aka 'int'} to 'const char*' [-fpermissive]<br> << ": Received " << qPrintable(id);<br> ^~<br>/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:108:52: error: 'QString::QString(const char*)' is private within this context<br> << ": Received " << qPrintable(id);<br> ^~~~~~~~~~<br>In file included from /usr/include/qt/QtCore/qobject.h:47,<br> from /usr/include/qt/QtCore/QObject:1,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:<br>/usr/include/qt/QtCore/qstring.h:829:5: note: declared private here<br> QString(const char *ch);<br> ^~~~~~~<br>In file included from /usr/include/qt/QtCore/qnamespace.h:43,<br> from /usr/include/qt/QtCore/qobjectdefs.h:48,<br> from /usr/include/qt/QtCore/qobject.h:46,<br> from /usr/include/qt/QtCore/QObject:1,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:<br>/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:108:63: error: invalid conversion from 'qint32' {aka 'int'} to 'const char*' [-fpermissive]<br> << ": Received " << qPrintable(id);<br> ^~<br>In file included from /usr/include/qt/QtCore/qobject.h:47,<br> from /usr/include/qt/QtCore/QObject:1,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:<br>/usr/include/qt/QtCore/qstring.h:829:25: note: initializing argument 1 of 'QString::QString(const char*)'<br> QString(const char *ch);<br> ~~~~~~~~~~~~^~<br>In file included from /usr/include/qt/QtCore/qnamespace.h:43,<br> from /usr/include/qt/QtCore/qobjectdefs.h:48,<br> from /usr/include/qt/QtCore/qobject.h:46,<br> from /usr/include/qt/QtCore/QObject:1,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.h:22,<br> from /home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:19:<br>/home/angel/src/kphotoalbum-Load-performance/RemoteControl/RemoteConnection.cpp:108:52: error: conversion to non-const reference type 'class QString&&' from rvalue of type 'QString' [-fpermissive]<br> << ": Received " << qPrintable(id);<br> ^~~~~~~~~~<br>make[2]: *** [CMakeFiles/kphotoalbum.dir/build.make:3053: CMakeFiles/kphotoalbum.dir/RemoteControl/RemoteConnection.cpp.o] Error 1<br>make[1]: *** [CMakeFiles/Makefile2:69: CMakeFiles/kphotoalbum.dir/all] Error 2<br>make: *** [Makefile:141: all] Error 2<br></div><div><br></div><div><br></div><div><br></div><div><br></div><div>Now, I have no idea about what to do. Could be related to Qt version?</div><div>I'm on Arch Linux and Qt-5.11</div><div><br></div><div>Regards, and thanks for your efforts to make kphotoalbum even better !!!<br></div></div><div class="gmail_extra"><br clear="all"><div><div class="gmail_signature" data-smartmail="gmail_signature"><br style="font-family:courier new,monospace"><span style="font-family:courier new,monospace">______________________________</span><br style="font-family:courier new,monospace"><span style="font-family:courier new,monospace">----------- Angel ------------<br><br style="font-family:courier new,monospace"></span></div></div>
<br><div class="gmail_quote">2018-06-02 17:37 GMT+02:00 Robert Krawitz <span dir="ltr"><<a href="mailto:rlk@alum.mit.edu" target="_blank">rlk@alum.mit.edu</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">BTW, has anyone else tested the load performance branch? This offers<br>
enough improvements when loading images (functional -- image stacking<br>
at load now fully works -- in addition to performance), and the<br>
possibility of fixing some threading issues, that I'd like to get it<br>
merged.<br>
<span class="im HOEnZb"><br>
-- <br>
Robert Krawitz <<a href="mailto:rlk@alum.mit.edu">rlk@alum.mit.edu</a>><br>
<br>
*** MIT Engineers A Proud Tradition <a href="http://mitathletics.com" rel="noreferrer" target="_blank">http://mitathletics.com</a> ***<br>
Member of the League for Programming Freedom -- <a href="http://ProgFree.org" rel="noreferrer" target="_blank">http://ProgFree.org</a><br>
Project lead for Gutenprint -- <a href="http://gimp-print.sourceforge.net" rel="noreferrer" target="_blank">http://gimp-print.sourceforge.<wbr>net</a><br>
<br>
"Linux doesn't dictate how I work, I dictate how Linux works."<br>
--Eric Crampton<br>
</span><div class="HOEnZb"><div class="h5">______________________________<wbr>_________________<br>
KPhotoAlbum mailing list<br>
<a href="mailto:KPhotoAlbum@mail.kdab.com">KPhotoAlbum@mail.kdab.com</a><br>
<a href="https://mail.kdab.com/mailman/listinfo/kphotoalbum" rel="noreferrer" target="_blank">https://mail.kdab.com/mailman/<wbr>listinfo/kphotoalbum</a><br>
</div></div></blockquote></div><br></div>