[KPhotoAlbum] Import crash

[Robert Krawitz]

On Thu, 18 May 2017 22:41:30 +0200, Johannes Zarl-Zierl wrote:
> On Mittwoch, 17. Mai 2017 21:59:56 CEST Robert Krawitz wrote:
>> >> One of the problems is with displaying the images page.
>> >> createImagesPage() is fast enough, but when it Qt then goes to display
>> >> it, it's deathly slow if there are a lot of images (presumably there's
>> >> some inefficiency in Qt with creating a dialog with thousands of
>> >> items in it -- or the way KPA is doing it, since file browsers have to
>> >> be able to display lots of items).  Even if I have it not try to
>> >> display a pixmap and/or label, it's very slow.
> [...]
>> I suspect QLayout isn't really designed for that many items; it's very
>> flexible and tries hard to achieve the best layout for the widgets you
>> put into it.  If I run it under gdb, and break into it, it looks like
>> it's spending a huge amount of time doing stuff like this (all inside
>> that ImportExport::ImportDialog::exec() call):
> [...]
>> For that matter, a lot of times when I'm doing an import I'm really
>> not interested in selecting which files I want to import; just grab
>> the whole thing and go.
>
> I've not recently looked at that part of the import process, but I would imagine that asking the user whether to display that dialog shouldn't be hard to do...

It looks like there are some side effects involved in creating that
dialog that set up the lists of metadata to import; if I don't
populate the list, the rest of the stuff doesn't happen.
-- 
Robert Krawitz                                     <rlk at alum.mit.edu>

***  MIT Engineers   A Proud Tradition   http://mitathletics.com  ***
Member of the League for Programming Freedom  --  http://ProgFree.org
Project lead for Gutenprint   --    http://gimp-print.sourceforge.net

"Linux doesn't dictate how I work, I dictate how Linux works."
--Eric Crampton