[KPhotoAlbum] kphotoalbum git not compiling

[Reimar Imhof]

Hi Johannes, hi Tobias,

thanks for the new patch.

I applied both patches (35d4a6d and 10421fc) at kphotoalbum 4.7 and it's much 
better now.
Your patch is better then my "simple" patch because it needs less strings 
(like "Folder" or "Media Type") but uses enum like 
DB::Category::FolderCategory.

There still is a smaller i18n issue, my patch didn't solve and your one 
doesn't solve either :-(
- Start kphotoalbum
- Select "Media Type" (in German "Medientyp")
- You get a table with media types "Image" and "Video" in the left column; 
well it should be "Bild" and "Video" (if you use German locale).
I reinstalled to old kphotoalbum 4.6.2 just for a test. It showed the 
translated items ("Bild"/"Video") as expected.
Sorry, I've no idea where to look for a fix. I searched for all occurrences of 
"Video" but couldn't find anything related to the missing translation.

What about having a 4.7.0.1 (or how ever you want to call it) after these 
problems are fixed?

Cheers, Reimar


Am Dienstag, 26. Januar 2016, 00:30:04 schrieb Johannes Zarl-Zierl:
> Hi Reimar,
> 
> On Monday 25 January 2016 22:18:33 Reimar Imhof wrote:
> > Johannes, I've tried your changes 35d4a6d, "Fix problems with i18n of
> > folder and media type c…".
> 
> I should have pushed these to a different branch, as they were not a full
> fix for the problem, yet. I had just done a quick push so that Tobias could
> test the changes. Sorry for the confusion.
> 
> > When I'm using your patch I just get a new folder called "unknown".
> > I've to save the database and restart kphotoalbum to get the correct name.
> > That problem even shows up when using C locale.
> > 
> > Perhaps you could have a look at this:
> > Put a new folder with some photos to your kphotoalbum folder and start
> > kphotoalbum and go to the folder category - the folder just shows up
> > without it's name...
> 
> Ah, yes, that was caused by an incorrect initialization of the special
> categories. This issue should be fixed now.
> 
> Cheers,
>   Johannes
> _______________________________________________
> KPhotoAlbum mailing list
> KPhotoAlbum at mail.kdab.com
> https://mail.kdab.com/mailman/listinfo/kphotoalbum