[KPhotoAlbum] Bug 150972 - change "no other" behavior when selecting directories

[Miika Turkia]

I am a bit in loss on what this code does. At least it seems to break
the None selection when selecting categories. (E.g. I select place
Maldives and then go select None from Latin Name (my custom category)
- this will select all the images from Maldives, when it should select
only the ones from Maldives that don't have the Latin Name set.
Without the patch my use case works properly.)

I thought that the original bug report was talking about the Folder
selection where you are currently able to select a subtree with every
directory under it.. while it would be useful to be able to select
images within the subdir without recursing to directories under it.

miika

On Mon, Feb 27, 2012 at 1:43 AM, Johannes Zarl <isilmendil at gmx.net> wrote:
> Hi,
>
> While digging into the mentioned bug, I reorganised the "No Others" Image
> Matcher:
>
> 0001-Replace-NoOtherCategoryMatcher-with-ExactCategoryMat.patch
> 0002-ImageSearchInfo.compile-omit-empty-andMatchers.patch
> 0003-Remove-NoOtherItemsCategoryMatcher.patch
> 0004-Remove-unused-code-from-DB-ExactCategoryMatcher.patch
>
> You can also apply this alone (which just fixes Bug 150972):
> 0005-Make-No-other-work-for-sub-categories.patch
>
> I know this is a realatively large changeset for little actual change, but let
> me make a stance for the new code:
>  + There is no longer a CategoryMatcher.finalize() step involved:
>   This means one less iteration over the whole matcher tree.
>  + shouldPrepareMatchedSet is only set for those parts of the matcher tree
> where it is actually needed
>  + mixing "No other" in different categories now works correctly
>  E.g.: "FolderA / **No other** / PersonB / **No other**"
>
> Cheers,
>  Johannes
>
> _______________________________________________
> KPhotoAlbum mailing list
> KPhotoAlbum at mail.kdab.com
> https://mail.kdab.com/mailman/listinfo/kphotoalbum
>