[KPhotoAlbum] Annotation Dialog with more enhancements (was 'Re: De-Selecting images dosn't work any more')

[Reimar Imhof]

Hi Jesper,
it should be && (logical and).
Regarding (3): There is a context menu to select super/sub categories. This 
all ready gives you the possibility to put something in two (ore more) super 
categories. I gave it a try (using xml backend) and it worked for me. So Ctrl-
Drag is just an other way to select a second super category.

I attach the reworked patch. It also changes my previous toggleSelection.patch 
with the same problem (should be &&...;-) ).

Reimar


Am Sonntag, 5. September 2010, 21:01:42 schrieb Jesper K. Pedersen:
> I'll let Miika work with you on this patch, just found one thing that looks
> wrong:
> -        if ( !oldParent.isEmpty() )
> +        if ( !oldParent.isEmpty() & e->dropAction()!=Qt::CopyAction )
>              memberMap.removeMemberFromGroup(
> _listView->category()->name(), oldParent, child );
>      }
> 
> Don't you mean && rather than & ?
> 
> Regarding (3): It has been ages since I've touched this code, but I fear
> what copy means. Can KPA handle that you a tag in multiple tag categories?
> Thats is what you get, right?
> 
> Cheers
> 
> On Friday 03 September 2010 21:40:08 Reimar Imhof wrote:
> | Am Montag, 30. August 2010, 20:32:58 schrieb Miika Turkia:
> | > Thanks a bunch, can't wait for your next patch ;)
> | > Committed revision 1170089.
> | 
> | Hi,
> | 
> | here it comes with three more enhancements in Annotation Dialog:
> | 1.) bug fix for filter button display. It was gone after beeing in search
> | mode. Now it shows up again when going to config mode again.
> | 2.) have +/- items on top level super categories in categories list view
> | (with tree sorting); this allows to collapse a whole super categorie.
> | 3.) allow copy per drag-and-drop (when ctrl is pressed) in categories
> | list view (with tree sorting). (Previously we only had a move per
> | drag-and-drop.)
> | 
> | Reimar

-------------- next part --------------
A non-text attachment was scrubbed...
Name: enhancementAnnotationDialogVers2.patch
Type: text/x-patch
Size: 2932 bytes
Desc: not available
URL: <http://mail.kde.org/pipermail/kphotoalbum/attachments/20100906/eb4cb7d0/attachment-0001.bin>