[KimDaBa] Fwd: MERGE ==> AND/OR in the search dialog

[Jesper K. Pedersen]

Sorry, this was in no way intended to go to the list. In general, I'm happy 
about your patches, I'm only trying to optimize MY time, so I can implement 
as many features in KimDaBa as possible ;-)

On Wednesday 29 December 2004 11:56, Jesper K. Pedersen wrote:
| OK. I've applied the patch now. Thanks.
|
| Please don't get me wrong, but could you please review your patches a few
| extra times before sending them to me.
| I've often found debug output in your patches, and this time I found this
| line:
| (*it)->setShowMergeCheckbox( _setup == MULTIPLE | _setup == SEARCH );
| (notice the single bar, which should have been a double bar)
|
| When writting code, please remember that readability and maintainability
| beats easy writting.
| Thus I dislike isBoxChecked() - it reveals no info to the reader what this
| is about.
| I'd rather like to see to methods doMerge() and isAND()
|
| Finally, I'd prefer if the AND checkbox was replaced with a "and/or" radio
| buttons. Please send me a patch with that change.
|
| Cheers
| Jesper.
|
| On Thursday 16 December 2004 16:24, Jean-Michel FAYARD wrote:
| | ---------- Forwarded message ----------
| | From: Jean-Michel FAYARD <jmfayard at gmail.com>
| | Date: Thu, 16 Dec 2004 16:05:37 +0100
| | Subject: MERGE ==> AND/OR in the search dialog
| | To: Kimdaba <kimdaba at klaralvdalens-datakonsult.se>
| |
| |
| | I just understood today for what the "Merge" checkbox in the search
| | dialog is relevant, ie for nothing.
| | So why not replace it (in the search dialog, not in the Configure image
| | dialog) with the more useful AND / OR checkbox ?
| |
| | Only problem now that we can do ORed search :
| | I have typically folders with long name (say
| | 2004-06-12_Karlsruhe_LinuxTag_with_Jesper ). When I want to select
| | pictures
| | from many directories, the path becomes very long, and KimDaBa takes
| | 3 time the width of the screen
| | (see http://www.stud.uni-karlsruhe.de/~upaxe/temp/BigBigPath.png )

-- 
Having trouble finding a given image in your collection containing
thousands of images?

http://ktown.kde.org/kimdaba might be the answer.