D18445: Fix missing parentheses around macro
Jiří Paleček
noreply at phabricator.kde.org
Tue Jan 22 02:37:50 GMT 2019
jpalecek created this revision.
Herald added a project: Kopete.
Herald added a subscriber: kopete-devel.
jpalecek requested review of this revision.
REVISION SUMMARY
Defining macro isRunning by
#define isRunning() something == something_else
has its problems. Elsewhere in the code, there is ```
if(!isRunning())
which expands to `!something == something_else`, not what you would probably mean. I have found this due to a gcc warning.
REPOSITORY
R434 Kopete
BRANCH
master
REVISION DETAIL
https://phabricator.kde.org/D18445
AFFECTED FILES
protocols/jabber/libjingle.cpp
To: jpalecek
Cc: kopete-devel, himanshuvishwakarma, cochise
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kopete-devel/attachments/20190122/ecf805c5/attachment.html>
More information about the kopete-devel
mailing list