Review Request 128863: Handle characters outside BMP in InsertCharDialog

Christoph Feck cfeck at kde.org
Wed Mar 29 13:32:07 UTC 2017


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128863/
-----------------------------------------------------------

(Updated March 29, 2017, 1:32 p.m.)


Status
------

This change has been marked as submitted.


Review request for Konversation.


Changes
-------

Submitted with commit b49e2a180f84d629863815143eb8783a07ae8dfc by Christoph Feck to branch 1.7.


Repository: konversation


Description
-------

The KCharSelect API was enhanced to support non-BMP characters (code points > 0xFFFF) since 5.25. Unicode 6 emoticons, for example, can now be browsed when the new API is used.

This patch modifies Konversation to use the new API.

Apply only when you can depend on KF5 5.25.


Diffs
-----

  src/viewer/insertchardialog.h 89fbf8f 
  src/viewer/insertchardialog.cpp 274413a 
  src/viewer/viewcontainer.h cf433c0 
  src/viewer/viewcontainer.cpp 1b1f320 

Diff: https://git.reviewboard.kde.org/r/128863/diff/


Testing
-------

Selecting an emoticon: showed up in konversation view, but I could not test if non-BMP characters are transmitted correctly.


Thanks,

Christoph Feck

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20170329/074835d1/attachment-0001.html>


More information about the Konversation-devel mailing list