Review Request 128863: Handle characters outside BMP in InsertCharDialog

[Eike Hein]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128863/#review102967
-----------------------------------------------------------


Ship it!




I've bumped minimum version requirements for KF and Qt in prep for this. Please commit ASAP to the 1.7 branch and then merge up into master.

- Eike Hein


On Sept. 8, 2016, 8:36 p.m., Christoph Feck wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128863/
> -----------------------------------------------------------
> 
> (Updated Sept. 8, 2016, 8:36 p.m.)
> 
> 
> Review request for Konversation.
> 
> 
> Repository: konversation
> 
> 
> Description
> -------
> 
> The KCharSelect API was enhanced to support non-BMP characters (code points > 0xFFFF) since 5.25. Unicode 6 emoticons, for example, can now be browsed when the new API is used.
> 
> This patch modifies Konversation to use the new API.
> 
> Apply only when you can depend on KF5 5.25.
> 
> 
> Diffs
> -----
> 
>   src/viewer/insertchardialog.h 89fbf8f 
>   src/viewer/insertchardialog.cpp 274413a 
>   src/viewer/viewcontainer.h cf433c0 
>   src/viewer/viewcontainer.cpp 1b1f320 
> 
> Diff: https://git.reviewboard.kde.org/r/128863/diff/
> 
> 
> Testing
> -------
> 
> Selecting an emoticon: showed up in konversation view, but I could not test if non-BMP characters are transmitted correctly.
> 
> 
> Thanks,
> 
> Christoph Feck
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20170329/6b231bfb/attachment.html>