Review Request 128222: Improve konversation support on OSX

[Peter Simonsson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128222/#review99176
-----------------------------------------------------------




data/CMakeLists.txt 
<https://git.reviewboard.kde.org/r/128222/#comment66773>

    I'm a bit out of touch with the latest conventions but this doesn't seem like the correct solution


- Peter Simonsson


On June 17, 2016, 10:35 a.m., Cristian Oneț wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128222/
> -----------------------------------------------------------
> 
> (Updated June 17, 2016, 10:35 a.m.)
> 
> 
> Review request for Konversation and Christoph Cullmann.
> 
> 
> Repository: konversation
> 
> 
> Description
> -------
> 
> Including cstdlib is necessary to fix the build otherwise std::abs can't be found.
> The rest of the build system changes allow the creation of a self contained application bundle with high dpi support and proper application icons.
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 2d7af35 
>   data/CMakeLists.txt 9873dd4 
>   data/MacOSXBundleInfo.plist.in PRE-CREATION 
>   data/konversation.qrc PRE-CREATION 
>   src/CMakeLists.txt f808bb9 
>   src/main.cpp 144254e 
>   src/viewer/viewcontainer.cpp ff20e6c 
> 
> Diff: https://git.reviewboard.kde.org/r/128222/diff/
> 
> 
> Testing
> -------
> 
> Successfully using konversation on OSX.
> 
> 
> Thanks,
> 
> Cristian Oneț
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20160914/92fa57ea/attachment.html>