Review Request 119256: Use more portable routines for byte swapping

[Peter Simonsson]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119256/#review98976
-----------------------------------------------------------


Ship it!




Ship It!

- Peter Simonsson


On July 14, 2014, 8:18 p.m., Vadim Zhukov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119256/
> -----------------------------------------------------------
> 
> (Updated July 14, 2014, 8:18 p.m.)
> 
> 
> Review request for Konversation and Bernd Buschinski.
> 
> 
> Repository: konversation
> 
> 
> Description
> -------
> 
> Konversation uses insane construction for byte-swapping routines. Given that it already uses sockets, it can use htonl() instead of trying bswap32() unconditionally (which is likely to be wrong on big-endian archs anyway). htonl() could be found on almost all *nix and also on Windows, and it's defined in POSIX.1. Despite of the name, it operates not on "long" but on 32-bit integers.
> 
> The given patch allows to compile Konversation on OpenBSD and should not break other OSes.
> 
> Please note that I don't have commit rights in KDE repos, so, if this patch will be accepted, someone will have to commit it on his own. Thanks.
> 
> 
> Diffs
> -----
> 
>   src/dcc/transfer.cpp 4485490 
>   src/dcc/transferrecv.cpp bf61f88 
>   src/dcc/transfersend.cpp 398191e 
> 
> Diff: https://git.reviewboard.kde.org/r/119256/diff/
> 
> 
> Testing
> -------
> 
> OpenBSD/i386-CURRENT
> 
> 
> Thanks,
> 
> Vadim Zhukov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20160907/6660a2ba/attachment.html>