[Konversation-devel] Review Request 126881: Fix alignment of RTL & LTR lines when application is translated to a RTL locale

[Safa Alfulaij]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126881/#review92311
-----------------------------------------------------------



Any update?

- Safa Alfulaij


On Jan. 27, 2016, 11:30 a.m., Safa Alfulaij wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126881/
> -----------------------------------------------------------
> 
> (Updated Jan. 27, 2016, 11:30 a.m.)
> 
> 
> Review request for Konversation and Eike Hein.
> 
> 
> Bugs: 346137
>     https://bugs.kde.org/show_bug.cgi?id=346137
> 
> 
> Repository: konversation
> 
> 
> Description
> -------
> 
> Alignment of lines get missy when you use the Arabic version of Konversation. This patch will resolve all of the line types and get rid of old code with new shorter code.
> Things to consider:
> * I am not a native English speaker.
> * I don't have any idea of how the coding style is, I just used what I saw in the file.
> * I don't know if there is a specific line width that I should consider.
> * There is a problem with emotions if placed between two Arabic words, they will be positioned wrongly (Reported to upstream: https://bugreports.qt.io/browse/QTBUG-50619)
> * I changed the way command messages got aligned, now it aligns according to the direction of the string rather than the count of RTL and LTR characters. It's better like this because an IP wouldn't contain RTL characters, which will make the count of LTR characters more, and that will aligns it to left, and will look bad.
> 
> More to be done:
> * Fix various issues with channel and nick names (Will be in a separate patch).
> 
> 
> Diffs
> -----
> 
>   src/viewer/ircview.cpp 58bda65 
> 
> Diff: https://git.reviewboard.kde.org/r/126881/diff/
> 
> 
> Testing
> -------
> 
> Tested all the types of lines and no issues at all. English version still looks as it is.
> Please ignore the command lines that are aligned to left, I just need to fix (Or copy-paste) the translation file.
> 
> 
> File Attachments
> ----------------
> 
> Server messages
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/25/89254d94-a636-4c7f-be32-d88ec298dec2__arabicLocale2.png
> Backlog, command and normal messages
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/25/c60a0232-8489-4cd3-bc64-c0887f1d8d30__arabicLocale3.png
> Normal, action and command messages
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/01/25/94fbc807-1bbb-4035-bde4-f8ca06badf65__arabicLocale.png
> 
> 
> Thanks,
> 
> Safa Alfulaij
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20160213/f41234ec/attachment.html>