Review Request 129701: Do not exit application if KDBusService fails to initialize.

[Gleb Popov]

> On Dec. 24, 2016, 5:04 p.m., Martin Blumenstingl wrote:
> > src/main.cpp, line 151
> > <https://git.reviewboard.kde.org/r/129701/diff/1/?file=488095#file488095line151>
> >
> >     shouldn't you move your code a bit further down so you're catching the "nui" case as well?

You are absuletely right, i missed that.


- Gleb


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129701/#review101566
-----------------------------------------------------------


On Dec. 24, 2016, 5:13 p.m., Gleb Popov wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129701/
> -----------------------------------------------------------
> 
> (Updated Dec. 24, 2016, 5:13 p.m.)
> 
> 
> Review request for Konversation.
> 
> 
> Repository: konversation
> 
> 
> Description
> -------
> 
> Pass `KDBusService::NoExitOnFailure` to `startupOptions`.
> 
> 
> Diffs
> -----
> 
>   src/main.cpp 8b4fd0f 
> 
> Diff: https://git.reviewboard.kde.org/r/129701/diff/
> 
> 
> Testing
> -------
> 
> Run on Windows without DBus and it works fine.
> 
> 
> Thanks,
> 
> Gleb Popov
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20161224/f1474106/attachment.html>