Review Request 129701: Do not exit application if KDBusService fails to initialize.
Martin Blumenstingl
martin.blumenstingl at googlemail.com
Sat Dec 24 14:04:45 UTC 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129701/#review101566
-----------------------------------------------------------
src/main.cpp (line 151)
<https://git.reviewboard.kde.org/r/129701/#comment67993>
shouldn't you move your code a bit further down so you're catching the "nui" case as well?
- Martin Blumenstingl
On Dec. 24, 2016, 1:53 p.m., Gleb Popov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129701/
> -----------------------------------------------------------
>
> (Updated Dec. 24, 2016, 1:53 p.m.)
>
>
> Review request for Konversation.
>
>
> Repository: konversation
>
>
> Description
> -------
>
> Pass `KDBusService::NoExitOnFailure` to `startupOptions`.
>
>
> Diffs
> -----
>
> src/main.cpp 8b4fd0f
>
> Diff: https://git.reviewboard.kde.org/r/129701/diff/
>
>
> Testing
> -------
>
> Run on Windows without DBus and it works fine.
>
>
> Thanks,
>
> Gleb Popov
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20161224/a469e793/attachment.html>
More information about the Konversation-devel
mailing list