[Konversation-devel] Review Request 124606: Fix some clang warnings.

[David Faure]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/124606/
-----------------------------------------------------------

(Updated Sept. 17, 2015, 6:40 a.m.)


Status
------

This change has been marked as submitted.


Review request for Konversation and Eike Hein.


Changes
-------

Submitted with commit 387ff3bed727fc89a2b3443d9d8cba7e7910c4de by David Faure to branch master.


Repository: konversation


Description
-------

I agree that a custom copy constructor doesn't really make sense if there's
no custom operator= (and operator= is indeed used); or vice versa, the
default copy ctor is incompatible with a custom destructor.

warning: definition of implicit copy assignment operator for 'ServerSettings' is deprecated because
   it has a user-declared destructor [-Wdeprecated]


Diffs
-----

  src/connectionsettings.h edc3ce08cdf95b7d0749a1f28749e90b509b44ec 
  src/connectionsettings.cpp 9fbd4b2cb31b5ec7c123f419b3e3af4c1a51e52f 
  src/irc/channel.h 25248aa8db67f1adeb2be98e178523f7784f4a84 
  src/irc/nicklistview.h 84913bcb33ba84eca2ce2d767f1aae9896c918b7 
  src/irc/server.h e7ffa87bcd8ce57937348b0e0bb76f97df6b4198 
  src/irc/server.cpp 6bc69ca87b2baff3bb209c085d94fa648f8feb33 
  src/irc/servergroupsettings.h c359967efcdd235a586d3105c843f47a3bb8fc1a 
  src/irc/servergroupsettings.cpp e99c291faf15ff3ebeadae18ecfa27ab2c27b8d6 
  src/irc/serversettings.h 6434d9289417e594aa9607229457f73aae748636 
  src/irc/serversettings.cpp 687e9eee7ff4f87350e96b9113767c4f439f4020 

Diff: https://git.reviewboard.kde.org/r/124606/diff/


Testing
-------


Thanks,

David Faure

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20150917/e4c85164/attachment.html>