<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124606/">https://git.reviewboard.kde.org/r/124606/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as submitted.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Konversation and Eike Hein.</div>
<div>By David Faure.</div>
<p style="color: grey;"><i>Updated Sept. 17, 2015, 6:40 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Submitted with commit 387ff3bed727fc89a2b3443d9d8cba7e7910c4de by David Faure to branch master.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konversation
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I agree that a custom copy constructor doesn't really make sense if there's
no custom operator= (and operator= is indeed used); or vice versa, the
default copy ctor is incompatible with a custom destructor.
warning: definition of implicit copy assignment operator for 'ServerSettings' is deprecated because
it has a user-declared destructor [-Wdeprecated]</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/connectionsettings.h <span style="color: grey">(edc3ce08cdf95b7d0749a1f28749e90b509b44ec)</span></li>
<li>src/connectionsettings.cpp <span style="color: grey">(9fbd4b2cb31b5ec7c123f419b3e3af4c1a51e52f)</span></li>
<li>src/irc/channel.h <span style="color: grey">(25248aa8db67f1adeb2be98e178523f7784f4a84)</span></li>
<li>src/irc/nicklistview.h <span style="color: grey">(84913bcb33ba84eca2ce2d767f1aae9896c918b7)</span></li>
<li>src/irc/server.h <span style="color: grey">(e7ffa87bcd8ce57937348b0e0bb76f97df6b4198)</span></li>
<li>src/irc/server.cpp <span style="color: grey">(6bc69ca87b2baff3bb209c085d94fa648f8feb33)</span></li>
<li>src/irc/servergroupsettings.h <span style="color: grey">(c359967efcdd235a586d3105c843f47a3bb8fc1a)</span></li>
<li>src/irc/servergroupsettings.cpp <span style="color: grey">(e99c291faf15ff3ebeadae18ecfa27ab2c27b8d6)</span></li>
<li>src/irc/serversettings.h <span style="color: grey">(6434d9289417e594aa9607229457f73aae748636)</span></li>
<li>src/irc/serversettings.cpp <span style="color: grey">(687e9eee7ff4f87350e96b9113767c4f439f4020)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124606/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>