[Konversation-devel] Review Request 116661: Added option to bypass the proxy when connecting to an IRC server

[Eli MacKenzie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116661/#review86944
-----------------------------------------------------------

Ship it!


> I'm wondering if I should also change other parts of this patch to use something like useGlobalProxy instead of bypassProxy, so the checkbox 'checked' property matches the internal state

No, I don't think so. The next revision to proxy support could include setting a specific proxy that is different from the system proxy. One might want to retain that proxy's settings and yet bypass it.

Please commit this to 1.6 and merge to master. Thanks!

- Eli MacKenzie


On Oct. 15, 2015, 6:33 p.m., Anselmo L. S. Melo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116661/
> -----------------------------------------------------------
> 
> (Updated Oct. 15, 2015, 6:33 p.m.)
> 
> 
> Review request for Konversation, Eli MacKenzie and Edward Baker.
> 
> 
> Bugs: 310544
>     https://bugs.kde.org/show_bug.cgi?id=310544
> 
> 
> Repository: konversation
> 
> 
> Description
> -------
> 
> Added an option to the server settings which allows direct connection to the IRC server, bypassing the proxy configured at settings -> configure Konversation -> behavior -> connection. It is usefull for environment where the user connects to an internal IRC server (without using a proxy) and external IRC servers (using the proxy).
> 
> I started implementing this adding all proxy configuration to each IRC server configuration, but, after checking how other popular IRC clients deal with this, I decided to proceed with this 'bypass' approach.
> 
> 
> Diffs
> -----
> 
>   src/application.cpp f66ab8c31f71ac4c2ce4ec221e690a5020619348 
>   src/irc/server.cpp e4a98808d6b20a0f45bf47cf42c1d9859b8cfe03 
>   src/irc/serverdialogui.ui 6871c13dc1cc6bac561df3e607630f36b2fc6465 
>   src/irc/servergroupdialog.cpp 61b8bd96dec2b0901e9fc3d1184d51cce0b2ebde 
>   src/irc/serversettings.h 2b6e068498aa94c20bd871a3add5c0da3e31cfd4 
>   src/irc/serversettings.cpp 53ec203de69ec1cae357a776132ed7952b2a1ed0 
> 
> Diff: https://git.reviewboard.kde.org/r/116661/diff/
> 
> 
> Testing
> -------
> 
> A proxy was configured, then two IRC servers were added: freenode.net (using the proxy) and an internal server (bypassing the proxy). Then konversation was connected to both simultaneously.
> 
> 
> Thanks,
> 
> Anselmo L. S. Melo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20151017/07070de9/attachment.html>