<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116661/">https://git.reviewboard.kde.org/r/116661/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm wondering if I should also change other parts of this patch to use something like useGlobalProxy instead of bypassProxy, so the checkbox 'checked' property matches the internal state</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No, I don't think so. The next revision to proxy support could include setting a specific proxy that is different from the system proxy. One might want to retain that proxy's settings and yet bypass it.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Please commit this to 1.6 and merge to master. Thanks!</p></pre>
<br />
<p>- Eli MacKenzie</p>
<br />
<p>On October 15th, 2015, 6:33 p.m. EDT, Anselmo L. S. Melo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Konversation, Eli MacKenzie and Edward Baker.</div>
<div>By Anselmo L. S. Melo.</div>
<p style="color: grey;"><i>Updated Oct. 15, 2015, 6:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=310544">310544</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konversation
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added an option to the server settings which allows direct connection to the IRC server, bypassing the proxy configured at settings -> configure Konversation -> behavior -> connection. It is usefull for environment where the user connects to an internal IRC server (without using a proxy) and external IRC servers (using the proxy).
I started implementing this adding all proxy configuration to each IRC server configuration, but, after checking how other popular IRC clients deal with this, I decided to proceed with this 'bypass' approach.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A proxy was configured, then two IRC servers were added: freenode.net (using the proxy) and an internal server (bypassing the proxy). Then konversation was connected to both simultaneously.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/application.cpp <span style="color: grey">(f66ab8c31f71ac4c2ce4ec221e690a5020619348)</span></li>
<li>src/irc/server.cpp <span style="color: grey">(e4a98808d6b20a0f45bf47cf42c1d9859b8cfe03)</span></li>
<li>src/irc/serverdialogui.ui <span style="color: grey">(6871c13dc1cc6bac561df3e607630f36b2fc6465)</span></li>
<li>src/irc/servergroupdialog.cpp <span style="color: grey">(61b8bd96dec2b0901e9fc3d1184d51cce0b2ebde)</span></li>
<li>src/irc/serversettings.h <span style="color: grey">(2b6e068498aa94c20bd871a3add5c0da3e31cfd4)</span></li>
<li>src/irc/serversettings.cpp <span style="color: grey">(53ec203de69ec1cae357a776132ed7952b2a1ed0)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116661/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>