[Konversation-devel] Review Request 110002: this fixes the nick auto-completion for (a<tab> types

[mayank jha]

> On April 18, 2013, 8:04 p.m., Eli MacKenzie wrote:
> > src/irc/channel.cpp, line 521
> > <https://git.reviewboard.kde.org/r/110002/diff/5/?file=138681#file138681line521>
> >
> >     use the simplified regex from above with QString::lastIndexOf, instead of looping and constructing a new QString for every backwards step

Does this need to be discarded ?


- mayank


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/110002/#review31263
-----------------------------------------------------------


On April 18, 2013, 8:57 p.m., mayank jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/110002/
> -----------------------------------------------------------
> 
> (Updated April 18, 2013, 8:57 p.m.)
> 
> 
> Review request for Konversation.
> 
> 
> Bugs: 235562
>     https://bugs.kde.org/show_bug.cgi?id=235562
> 
> 
> Repository: konversation
> 
> 
> Description
> -------
> 
> "(a<tab>" won't complete any nicks starting with "a", for example. "(" shouldn't factor into the prefix, however, since it's not allowed within nicks.
> 
> 
> Diffs
> -----
> 
>   src/irc/channel.cpp f055213 
> 
> Diff: https://git.reviewboard.kde.org/r/110002/diff/
> 
> 
> Testing
> -------
> 
> runs fine!
> 
> 
> Thanks,
> 
> mayank jha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20140318/95b21cdc/attachment.html>