[Konversation-devel] Review Request 116661: Added option to bypass the proxy when connecting to an IRC server

[Anselmo L. S. Melo]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116661/#review52406
-----------------------------------------------------------



src/irc/server.cpp
<https://git.reviewboard.kde.org/r/116661/#comment37081>

    I checked the code of KTcpSocket and the "policy" argument actually doesn't change the behavior of connectToHost. Leave it untouched or keep this change?


- Anselmo L. S. Melo


On March 8, 2014, 2:04 p.m., Anselmo L. S. Melo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116661/
> -----------------------------------------------------------
> 
> (Updated March 8, 2014, 2:04 p.m.)
> 
> 
> Review request for Konversation.
> 
> 
> Bugs: 310544
>     https://bugs.kde.org/show_bug.cgi?id=310544
> 
> 
> Repository: konversation
> 
> 
> Description
> -------
> 
> Added an option to the server settings which allows direct connection to the IRC server, bypassing the proxy configured at settings -> configure Konversation -> behavior -> connection. It is usefull for environment where the user connects to an internal IRC server (without using a proxy) and external IRC servers (using the proxy).
> 
> I started implementing this adding all proxy configuration to each IRC server configuration, but, after checking how other popular IRC clients deal with this, I decided to proceed with this 'bypass' approach.
> 
> 
> Diffs
> -----
> 
>   src/irc/serversettings.h 6434d92 
>   src/irc/serversettings.cpp 687e9ee 
>   src/irc/serverdialogui.ui 6871c13 
>   src/irc/servergroupdialog.cpp 75655b3 
>   src/irc/server.cpp 6f68264 
>   src/application.cpp 5c0e721 
> 
> Diff: https://git.reviewboard.kde.org/r/116661/diff/
> 
> 
> Testing
> -------
> 
> A proxy was configured, then two IRC servers were added: freenode.net (using the proxy) and an internal server (bypassing the proxy). Then konversation was connected to both simultaneously.
> 
> 
> Thanks,
> 
> Anselmo L. S. Melo
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20140308/b3efa906/attachment.html>