<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116661/">https://git.reviewboard.kde.org/r/116661/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/116661/diff/1/?file=252987#file252987line510" style="color: black; font-weight: bold; text-decoration: underline;">src/irc/server.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void Server::connectToIRCServer()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">503</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_socket</span><span class="o">-></span><span class="n">connectToHost</span><span class="p">(</span><span class="n">getConnectionSettings</span><span class="p">().</span><span class="n">server</span><span class="p">().</span><span class="n">host</span><span class="p">(),</span> <span class="n">getConnectionSettings</span><span class="p">().</span><span class="n">server</span><span class="p">().</span><span class="n">port</span><span class="p">());</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">510</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_socket</span><span class="o">-></span><span class="n">connectToHost</span><span class="p">(</span><span class="n">getConnectionSettings</span><span class="p">().</span><span class="n">server</span><span class="p">().</span><span class="n">host</span><span class="p">(),</span> <span class="n">getConnectionSettings</span><span class="p">().</span><span class="n">server</span><span class="p">().</span><span class="n">port</span><span class="p">()<span class="hl">,</span></span><span class="hl"> </span><span class="n"><span class="hl">proxyPolicy</span></span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I checked the code of KTcpSocket and the "policy" argument actually doesn't change the behavior of connectToHost. Leave it untouched or keep this change?</pre>
</div>
<br />
<p>- Anselmo L. S. Melo</p>
<br />
<p>On March 8th, 2014, 2:04 p.m. BRT, Anselmo L. S. Melo wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Konversation.</div>
<div>By Anselmo L. S. Melo.</div>
<p style="color: grey;"><i>Updated March 8, 2014, 2:04 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=310544">310544</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
konversation
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Added an option to the server settings which allows direct connection to the IRC server, bypassing the proxy configured at settings -> configure Konversation -> behavior -> connection. It is usefull for environment where the user connects to an internal IRC server (without using a proxy) and external IRC servers (using the proxy).
I started implementing this adding all proxy configuration to each IRC server configuration, but, after checking how other popular IRC clients deal with this, I decided to proceed with this 'bypass' approach.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A proxy was configured, then two IRC servers were added: freenode.net (using the proxy) and an internal server (bypassing the proxy). Then konversation was connected to both simultaneously.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/irc/serversettings.h <span style="color: grey">(6434d92)</span></li>
<li>src/irc/serversettings.cpp <span style="color: grey">(687e9ee)</span></li>
<li>src/irc/serverdialogui.ui <span style="color: grey">(6871c13)</span></li>
<li>src/irc/servergroupdialog.cpp <span style="color: grey">(75655b3)</span></li>
<li>src/irc/server.cpp <span style="color: grey">(6f68264)</span></li>
<li>src/application.cpp <span style="color: grey">(5c0e721)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116661/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>