[Konversation-devel] Review Request 109659: this patch adds the feature of Ctrl+Mouse to increase/decrease the font size of the ircview

[Eli MacKenzie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109659/#review29871
-----------------------------------------------------------



src/viewer/ircinput.h
<http://git.reviewboard.kde.org/r/109659/#comment22225>

    put the blank line back



src/viewer/ircinput.h
<http://git.reviewboard.kde.org/r/109659/#comment22224>

    put the blank line back



src/viewer/ircinput.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22223>

    put the blank line back



src/viewer/ircview.h
<http://git.reviewboard.kde.org/r/109659/#comment22231>

    move these two lines to the end of the last "public slots:" section in the file, dont' forget to put the blank line back here!



src/viewer/ircview.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22222>

    add a blank line after this line



src/viewer/ircview.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22221>

    don't add this blank line



src/viewer/ircview.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22219>

    needs to have a space on both sides of the <, and a space before decreaseFontSize



src/viewer/ircview.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22220>

    similar to the previous line



src/viewer/ircview.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22226>

    remove this blank line



src/viewer/viewcontainer.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22227>

    move this back to line 34



src/viewer/viewcontainer.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22228>

    the else and return are unnecessary



src/viewer/viewcontainer.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22229>

    the else and return are unnecessary



src/viewer/viewcontainer.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22230>

    remove this blank line


- Eli MacKenzie


On March 25, 2013, 1:44 p.m., mayank jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109659/
> -----------------------------------------------------------
> 
> (Updated March 25, 2013, 1:44 p.m.)
> 
> 
> Review request for Konversation.
> 
> 
> Description
> -------
> 
> this enable konversation to use the additional feature of mouse zooming in irc view
> 
> 
> This addresses bug 306545.
>     https://bugs.kde.org/show_bug.cgi?id=306545
> 
> 
> Diffs
> -----
> 
>   src/mainwindow.cpp 4c09a18 
>   src/viewer/ircinput.h a6256ed 
>   src/viewer/ircinput.cpp 041eadb 
>   src/viewer/ircview.h 789e0c9 
>   src/viewer/ircview.cpp 3bea089 
>   src/viewer/viewcontainer.h 966a100 
>   src/viewer/viewcontainer.cpp ffa40ba 
> 
> Diff: http://git.reviewboard.kde.org/r/109659/diff/
> 
> 
> Testing
> -------
> 
> working fine!
> 
> 
> Thanks,
> 
> mayank jha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20130325/7673ca61/attachment.html>