[Konversation-devel] Review Request 109659: this patch adds the feature of Ctrl+Mouse to increase/decrease the font size of the ircview

[Eli MacKenzie]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/109659/#review29868
-----------------------------------------------------------



src/mainwindow.h
<http://git.reviewboard.kde.org/r/109659/#comment22197>

    put the blank line back



src/viewer/ircinput.h
<http://git.reviewboard.kde.org/r/109659/#comment22198>

    put the blank line back



src/viewer/ircinput.h
<http://git.reviewboard.kde.org/r/109659/#comment22199>

    put the blank line back



src/viewer/ircinput.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22200>

    put the blank line back



src/viewer/ircview.h
<http://git.reviewboard.kde.org/r/109659/#comment22201>

    don't add this blank line



src/viewer/ircview.h
<http://git.reviewboard.kde.org/r/109659/#comment22202>

    put the blank line back



src/viewer/ircview.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22203>

    put the blank line back



src/viewer/ircview.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22204>

    don't add this blank line



src/viewer/ircview.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22205>

    put a blank line before this line, and indent this line properly



src/viewer/viewcontainer.h
<http://git.reviewboard.kde.org/r/109659/#comment22206>

    change zoomin to zoomIn



src/viewer/viewcontainer.h
<http://git.reviewboard.kde.org/r/109659/#comment22207>

    change zoomout to zoomOut



src/viewer/viewcontainer.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22208>

    why did you add this #include?



src/viewer/viewcontainer.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22209>

    put the blank line back



src/viewer/viewcontainer.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22215>

    you need to ensure that getTextView returns a valid pointer, this will crash if the front view doesn't have a text view



src/viewer/viewcontainer.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22210>

    need a blank line before this



src/viewer/viewcontainer.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22216>

    you need to ensure that getTextView returns a valid pointer, this will crash if the front view doesn't have a text view



src/viewer/viewcontainer.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22211>

    need a blank line after this



src/viewer/viewcontainer.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22212>

    put this back the way it was



src/viewer/viewcontainer.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22213>

    put the blank line back



src/viewer/viewcontainer.cpp
<http://git.reviewboard.kde.org/r/109659/#comment22214>

    don't add this blank line


- Eli MacKenzie


On March 25, 2013, 1:15 p.m., mayank jha wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/109659/
> -----------------------------------------------------------
> 
> (Updated March 25, 2013, 1:15 p.m.)
> 
> 
> Review request for Konversation.
> 
> 
> Description
> -------
> 
> this enable konversation to use the additional feature of mouse zooming in irc view
> 
> 
> This addresses bug 306545.
>     https://bugs.kde.org/show_bug.cgi?id=306545
> 
> 
> Diffs
> -----
> 
>   src/viewer/ircinput.h a6256ed 
>   src/mainwindow.h 6edb4be 
>   src/mainwindow.cpp 4c09a18 
>   src/viewer/ircinput.cpp 041eadb 
>   src/viewer/ircview.h 789e0c9 
>   src/viewer/ircview.cpp 3bea089 
>   src/viewer/viewcontainer.h 966a100 
>   src/viewer/viewcontainer.cpp ffa40ba 
> 
> Diff: http://git.reviewboard.kde.org/r/109659/diff/
> 
> 
> Testing
> -------
> 
> working fine!
> 
> 
> Thanks,
> 
> mayank jha
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/konversation-devel/attachments/20130325/930d0205/attachment-0001.html>